Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove proxy-rewrite plugin out of create plugin template config view #1723

Merged
merged 4 commits into from
Apr 11, 2021

Conversation

liuxiran
Copy link
Contributor

@liuxiran liuxiran commented Apr 8, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

While checking #1719 , another bug happened, proxy-rewrite plugin can still be configed in plugin template page.
Remove proxy-rewrite out of create plugin template config step2 , just keep the same as the create route step3 does.

Related issues

fix/resolve None

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@imjoey imjoey changed the title fix: remote proxy-rewrite plugin out of create plugin template config view fix: remove proxy-rewrite plugin out of create plugin template config view Apr 11, 2021
Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks, @liuxiran.

@imjoey imjoey merged commit 990662a into apache:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants