Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added i18n for RawDataEditor & Plugin Drawer #1747

Merged
merged 2 commits into from Apr 12, 2021

Conversation

juzhiyuan
Copy link
Member

@juzhiyuan juzhiyuan commented Apr 11, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

  • added i18n for RawDataEditor & Plugin Drawer
  • adjust button positions

Related issues

None

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Screenshots

image

image

@juzhiyuan juzhiyuan requested a review from LiteSun April 11, 2021 09:30
@codecov-io
Copy link

codecov-io commented Apr 11, 2021

Codecov Report

Merging #1747 (942947e) into master (8b6080d) will decrease coverage by 20.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1747       +/-   ##
===========================================
- Coverage   72.45%   52.29%   -20.16%     
===========================================
  Files         132       38       -94     
  Lines        5721     2660     -3061     
  Branches      649        0      -649     
===========================================
- Hits         4145     1391     -2754     
+ Misses       1334     1081      -253     
+ Partials      242      188       -54     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test 52.29% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-74.77%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-55.47%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/data_loader/route_import.go 27.41% <0.00%> (-37.50%) ⬇️
api/internal/handler/handler.go 42.59% <0.00%> (-35.19%) ⬇️
api/internal/handler/schema/schema.go 66.66% <0.00%> (-33.34%) ⬇️
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6080d...942947e. Read the comment docs.

Copy link
Member

@LiteSun LiteSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@membphis
Copy link
Member

membphis commented Apr 11, 2021

image

we can do this later, please create an issue and implement it later

@juzhiyuan
Copy link
Member Author

@membphis Please see this PR's description, it supports i18n already :)

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juzhiyuan juzhiyuan merged commit 36f371f into apache:master Apr 12, 2021
@juzhiyuan juzhiyuan deleted the juzhiyuan/plugin-drawer branch April 12, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants