fix: upstream host form warning message #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EricSyh <ericshenyuhao@outlook.com>
|
Deploy preview for apisix-dashboard ready! Built with commit 00cf1ed |
Signed-off-by: EricSyh <ericshenyuhao@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #1782 +/- ##
=======================================
Coverage 72.12% 72.12%
=======================================
Files 125 125
Lines 2906 2906
Branches 699 699
=======================================
Hits 2096 2096
Misses 810 810
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
juzhiyuan
approved these changes
Apr 17, 2021
liuxiran
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: EricSyh ericshenyuhao@outlook.com
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
The warning message of host form on upstream/services create pages uses raw regexp as below which is unfriendly to users.
So i modified nodes component under upstream to add an easy-to-understand warning message look like:
Related issues
No related issues.
Checklist: