Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve the Duplicate Route feature #1833

Merged
merged 1 commit into from May 6, 2021

Conversation

qian0817
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

clear the route name blank when duplicate route.

Related issues

fix/resolve #1703

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 28, 2021

Deploy preview for apisix-dashboard ready!

Built with commit fa5988d

https://deploy-preview-1833--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

Codecov Report

Merging #1833 (bac6de9) into master (2f3717f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head bac6de9 differs from pull request most recent head fa5988d. Consider uploading reports for the commit fa5988d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1833      +/-   ##
==========================================
+ Coverage   72.07%   72.10%   +0.02%     
==========================================
  Files         125      125              
  Lines        2944     2947       +3     
  Branches      711      712       +1     
==========================================
+ Hits         2122     2125       +3     
  Misses        822      822              
Flag Coverage Δ
frontend-e2e-test 72.10% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/Create.tsx 90.99% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6d7fc...fa5988d. Read the comment docs.

@starsz starsz requested review from LiteSun and juzhiyuan May 2, 2021 15:17
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tip!

@juzhiyuan juzhiyuan requested review from bzp2010 and liuxiran May 4, 2021 15:18
@juzhiyuan juzhiyuan merged commit b1e66a2 into apache:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve the Duplicate Route feature
5 participants