Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): allowing limit-conn to dynamically adapt to the BE rules #1990

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

wmdmomo
Copy link
Contributor

@wmdmomo wmdmomo commented Jul 21, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

The PR will change the plugin under plugin/UI (limit-conn), allowing limit-conn to dynamically adapt to the back-end json rules.

Related issues

fix/resolve #1588

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 21, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 2015ae7

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/610fd86c3cbf7000078ad1d6

😎 Browse the preview: https://deploy-preview-1990--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #1990 (2015ae7) into master (5a581d3) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
+ Coverage   65.69%   65.77%   +0.07%     
==========================================
  Files         121      121              
  Lines        3204     3205       +1     
  Branches      778      778              
==========================================
+ Hits         2105     2108       +3     
+ Misses       1099     1097       -2     
Flag Coverage Δ
frontend-e2e-test 65.77% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/UI/limit-conn.tsx 100.00% <100.00%> (ø)
web/src/components/Plugin/UI/plugin.tsx 83.33% <100.00%> (ø)
web/src/helpers.tsx 72.13% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a581d3...2015ae7. Read the comment docs.

@LiteSun LiteSun changed the title feat(plugin): fix UI limit-conn feat(plugin): allowing limit-conn to dynamically adapt to the BE rules Jul 26, 2021
@liuxiran
Copy link
Contributor

liuxiran commented Aug 7, 2021

@wmdmomo please fix conflict files when you have time thanks

@wmdmomo wmdmomo closed this Aug 8, 2021
@wmdmomo wmdmomo reopened this Aug 8, 2021
@wmdmomo
Copy link
Contributor Author

wmdmomo commented Aug 8, 2021

@liuxiran I have resolved the conflict.

@LiteSun LiteSun merged commit 930e47a into apache:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize front-end validation of fields
6 participants