-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): allowing limit-count to dynamically adapt to the BE rules #1998
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: d811800 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/611109e14aeefe0008768f06 😎 Browse the preview: https://deploy-preview-1998--apisix-dashboard.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## master #1998 +/- ##
==========================================
+ Coverage 64.01% 64.06% +0.05%
==========================================
Files 122 122
Lines 3154 3164 +10
Branches 753 755 +2
==========================================
+ Hits 2019 2027 +8
- Misses 1135 1137 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
merged, thanks a lot |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
The PR will change the plugin under plugin/UI (limit-count), allowing limit-count to dynamically adapt to the back-end json rules.
Related issues
fix/resolve #1588
Checklist: