Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): allowing proxy-mirror to dynamically adapt to the BE rules #2000

Merged
merged 3 commits into from
Aug 20, 2021

Conversation

wmdmomo
Copy link
Contributor

@wmdmomo wmdmomo commented Jul 25, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

The PR will change the plugin under plugin/UI (proxy-mirror), allowing proxy-mirror to dynamically adapt to the back-end json rules.

Related issues

fix/resolve #1588

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 25, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: f8ea499

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/61110835758db300073521b6

😎 Browse the preview: https://deploy-preview-2000--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #2000 (be0cfe0) into master (1cb7cb0) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head be0cfe0 differs from pull request most recent head f8ea499. Consider uploading reports for the commit f8ea499 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2000      +/-   ##
==========================================
+ Coverage   65.86%   65.94%   +0.07%     
==========================================
  Files         121      121              
  Lines        3211     3212       +1     
  Branches      779      779              
==========================================
+ Hits         2115     2118       +3     
+ Misses       1096     1094       -2     
Flag Coverage Δ
frontend-e2e-test 65.94% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/UI/plugin.tsx 83.33% <100.00%> (ø)
web/src/components/Plugin/UI/proxy-mirror.tsx 100.00% <100.00%> (ø)
web/src/helpers.tsx 73.77% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb7cb0...f8ea499. Read the comment docs.

@LiteSun LiteSun changed the title feat(plugin): fix UI proxy-mirror feat(plugin): allowing proxy-mirror to dynamically adapt to the BE rules Jul 26, 2021
@LiteSun LiteSun requested a review from liuxiran July 29, 2021 01:07
@LiteSun LiteSun requested a review from bzp2010 August 20, 2021 03:18
@liuxiran liuxiran merged commit 0ee6656 into apache:master Aug 20, 2021
@liuxiran
Copy link
Contributor

merged, thanks for your contribution @wmdmomo

@liuxiran
Copy link
Contributor

I noticed that in the schema of proxy-mirror, there is a required item in it

image

we can also add a required rule for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize front-end validation of fields
6 participants