-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add required flag for Route name field #2025
Conversation
…-count" This reverts commit d062dc4
add required tip for service name
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 6abd22d 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/61091030a59fd10007479e20 😎 Browse the preview: https://deploy-preview-2025--apisix-dashboard.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, and please add the related test case for your changes.
Codecov Report
@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
- Coverage 67.92% 64.03% -3.90%
==========================================
Files 182 121 -61
Lines 6978 3156 -3822
Branches 754 753 -1
==========================================
- Hits 4740 2021 -2719
+ Misses 1951 1135 -816
+ Partials 287 0 -287
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
web/src/pages/Route/components/DebugViews/AuthenticationView.tsx
Outdated
Show resolved
Hide resolved
Please add the related test case for your changes, thanks very much~ Hope this will help you to add your test case : https://stackoverflow.com/questions/55516990/cypress-testing-pseudo-css-class-before |
@liuxiran Only document changes are involved this time. |
And also the |
Yep, need test case for this |
the test case has been added. @juzhiyuan @liuxiran |
merged, thanks for your contribution~!! @okaybase |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve
Checklist: