Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid nil pointer dereference and remove redundant code #2031

Merged
merged 8 commits into from
Aug 4, 2021
Merged

fix: avoid nil pointer dereference and remove redundant code #2031

merged 8 commits into from
Aug 4, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Aug 3, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve:

  1. avoid nil pointer dereference
  2. remove redundant code

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: b48c84f

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/61091425d5c74e0007fdcac2

😎 Browse the preview: https://deploy-preview-2031--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #2031 (2291022) into master (fe6e155) will increase coverage by 3.94%.
The diff coverage is 66.66%.

❗ Current head 2291022 differs from pull request most recent head b48c84f. Consider uploading reports for the commit b48c84f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
+ Coverage   64.03%   67.98%   +3.94%     
==========================================
  Files         121      181      +60     
  Lines        3156     6971    +3815     
  Branches      753      753              
==========================================
+ Hits         2021     4739    +2718     
- Misses       1135     1946     +811     
- Partials        0      286     +286     
Flag Coverage Δ
backend-e2e-test 46.97% <66.66%> (?)
backend-e2e-test-ginkgo 49.33% <0.00%> (?)
backend-unit-test 53.24% <66.66%> (?)
frontend-e2e-test 64.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/data_loader/route_export.go 75.00% <66.66%> (ø)
api/internal/core/store/store.go 89.47% <0.00%> (ø)
api/internal/core/store/store_mock.go 0.00% <0.00%> (ø)
api/internal/handler/consumer/consumer.go 92.06% <0.00%> (ø)
api/internal/filter/schema.go 56.00% <0.00%> (ø)
api/internal/handler/label/label.go 86.20% <0.00%> (ø)
api/internal/utils/runtime/runtime.go 66.66% <0.00%> (ø)
api/internal/core/storage/etcd.go 51.18% <0.00%> (ø)
api/internal/filter/recover.go 7.69% <0.00%> (ø)
api/internal/utils/pid.go 42.85% <0.00%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6e155...b48c84f. Read the comment docs.

@juzhiyuan juzhiyuan merged commit 5843138 into apache:master Aug 4, 2021
@okaybase okaybase deleted the patch-api branch August 4, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants