Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use build-tools v2.0.0 instead of master #2083

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Aug 24, 2021

Signed-off-by: imjoey majunjie@apache.org

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

The apisix-dashboard CI is using the master code of apisix-build-tools for building and packaging. While this would lead to unexpected errors if anything is incompatible. In other words, we should always rely on a stable version. This PR is going to use the v2.0.0 of apisix-build-tools, which is also heading to the same commit with the latest code of the current master branch.

Related issues

Related to api7/apisix-build-tools#75.

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: imjoey <majunjie@apache.org>
@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 9fc9988

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/612485e2c6e35e0007ab306c

😎 Browse the preview: https://deploy-preview-2083--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #2083 (9fc9988) into master (9b18c35) will increase coverage by 3.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2083      +/-   ##
==========================================
+ Coverage   65.82%   69.02%   +3.20%     
==========================================
  Files         181      181              
  Lines        7010     7010              
  Branches      787      787              
==========================================
+ Hits         4614     4839     +225     
+ Misses       2112     1887     -225     
  Partials      284      284              
Flag Coverage Δ
backend-e2e-test 47.34% <ø> (ø)
backend-e2e-test-ginkgo 49.24% <ø> (?)
backend-unit-test 52.98% <ø> (+0.03%) ⬆️
frontend-e2e-test 66.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/validate.go 71.71% <0.00%> (+2.52%) ⬆️
api/internal/core/store/store.go 89.47% <0.00%> (+2.63%) ⬆️
api/internal/handler/service/service.go 92.74% <0.00%> (+3.22%) ⬆️
api/internal/handler/upstream/upstream.go 92.10% <0.00%> (+5.26%) ⬆️
api/internal/filter/authentication.go 78.94% <0.00%> (+5.26%) ⬆️
api/internal/handler/ssl/ssl.go 74.40% <0.00%> (+5.68%) ⬆️
api/internal/handler/route/route.go 80.23% <0.00%> (+7.75%) ⬆️
api/internal/handler/schema/schema.go 100.00% <0.00%> (+8.00%) ⬆️
api/internal/handler/handler.go 79.31% <0.00%> (+8.62%) ⬆️
api/internal/core/store/storehub.go 71.30% <0.00%> (+9.56%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b18c35...9fc9988. Read the comment docs.

@liuxiran liuxiran requested a review from bzp2010 August 24, 2021 06:05
@imjoey imjoey merged commit fb78963 into apache:master Aug 24, 2021
@imjoey imjoey deleted the feat/build_tools_v2.0.0 branch August 24, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants