Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: after enable redirect HTTPS, websocket form field disappeared #2115

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Sep 2, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
fix: after enable redirect HTTPS, websocket form field disappeared

Related issues

fix #2087
Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Sep 2, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 8089ceb

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/61309862d016d40008481dc2

😎 Browse the preview: https://deploy-preview-2115--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

Codecov Report

Merging #2115 (8089ceb) into master (528699d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2115      +/-   ##
==========================================
+ Coverage   67.27%   67.31%   +0.04%     
==========================================
  Files         124      124              
  Lines        3279     3277       -2     
  Branches      799      797       -2     
==========================================
  Hits         2206     2206              
+ Misses       1073     1071       -2     
Flag Coverage Δ
frontend-e2e-test 67.31% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/components/Step1/MetaView.tsx 100.00% <100.00%> (ø)
web/src/helpers.tsx 73.77% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528699d...8089ceb. Read the comment docs.

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@imjoey imjoey merged commit a5e07a2 into apache:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: after enable redirect HTTPS, websocket form field disappeared
5 participants