Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Manager API run on windows #2125

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Sep 7, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve:
support dashboard run on windows

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Sep 7, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 599869b

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6136d8d643f4930007e22847

😎 Browse the preview: https://deploy-preview-2125--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

Codecov Report

Merging #2125 (599869b) into master (fc89bc4) will decrease coverage by 16.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2125       +/-   ##
===========================================
- Coverage   69.34%   52.74%   -16.61%     
===========================================
  Files         186       38      -148     
  Lines        7073     2935     -4138     
  Branches      802        0      -802     
===========================================
- Hits         4905     1548     -3357     
+ Misses       1883     1193      -690     
+ Partials      285      194       -91     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test 52.74% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/main.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-90.91%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-71.31%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-70.00%) ⬇️
api/internal/utils/closer.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-56.00%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/utils/pid.go 0.00% <0.00%> (-42.86%) ⬇️
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc89bc4...599869b. Read the comment docs.

@okaybase okaybase changed the title feat: support dashboard run on windows feat: support Manager API run on windows Sep 7, 2021
Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nic-chen nic-chen merged commit 98fe38a into apache:master Sep 8, 2021
@okaybase okaybase deleted the win branch September 8, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants