Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update FAQ.md #2126

Merged
merged 3 commits into from
Sep 10, 2021
Merged

docs: Update FAQ.md #2126

merged 3 commits into from
Sep 10, 2021

Conversation

wjmmjr
Copy link
Contributor

@wjmmjr wjmmjr commented Sep 7, 2021

solve the problem of grafana page embedding

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2122

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

solve the problem of grafana page embedding
@netlify
Copy link

netlify bot commented Sep 7, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 786a387

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/613825db357ba10007aa7c62

😎 Browse the preview: https://deploy-preview-2126--apisix-dashboard.netlify.app

@liuxiran liuxiran changed the title Update FAQ.md docs: Update FAQ.md Sep 7, 2021
docs/en/latest/FAQ.md Outdated Show resolved Hide resolved
docs/en/latest/FAQ.md Outdated Show resolved Hide resolved
@liuxiran
Copy link
Contributor

liuxiran commented Sep 7, 2021

Thanks for your contribution @wjmmjr ~! You can try to fix the Lint error when you have time

@liuxiran
Copy link
Contributor

liuxiran commented Sep 9, 2021

also cc @guoqqqi @Baoyuantop to have a look thanks

@liuxiran liuxiran merged commit b5af46c into apache:master Sep 10, 2021
@liuxiran
Copy link
Contributor

merged, thanks for @wjmmjr's contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request help: could not login grafana
5 participants