-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: select Use the domain or IP from Node List #2168
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2168 +/- ##
==========================================
- Coverage 69.34% 68.24% -1.11%
==========================================
Files 188 127 -61
Lines 7161 3347 -3814
Branches 823 823
==========================================
- Hits 4966 2284 -2682
+ Misses 1906 1063 -843
+ Partials 289 0 -289
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Hi, @okaybase. Thank you for your contribution. After testing, I found some problems.
Please test it to confirm whether there is this problem. 🤔 |
@bzp2010 after confirm and testing again, maybe the current logic for your test case is reasonable. |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
When create Upstream and select
![image](https://user-images.githubusercontent.com/75366457/136787814-3bbc3a37-2b2c-45c3-a471-d2143fcf3b8a.png)
Use the domain or IP from Node List
, v2.8/v2.9.0 tip this and unable to select:Related issues
fix/resolve:
![image](https://user-images.githubusercontent.com/75366457/136786830-5f646565-fe2d-492f-8a4e-02d638d8d783.png)
PR(2118) change
name="nodes"
toname="submitNodes"
, so this PR sync the change in the file PassHost.tsxChecklist: