Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the property name for tcp_failures #2221

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Nov 23, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Correct the property name for tcp_failures.

Related issues

fix/resolve #2220

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #2221 (b1e6fc5) into master (ebf381d) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2221      +/-   ##
==========================================
- Coverage   68.13%   68.07%   -0.06%     
==========================================
  Files         127      127              
  Lines        3352     3352              
  Branches      824      824              
==========================================
- Hits         2284     2282       -2     
- Misses       1068     1070       +2     
Flag Coverage Δ
frontend-e2e-test 68.07% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/active-check/Unhealthy/TCPFailures.tsx 100.00% <ø> (ø)
web/src/helpers.tsx 70.49% <0.00%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebf381d...b1e6fc5. Read the comment docs.

@bzp2010 bzp2010 merged commit a381b61 into apache:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the TCP Failures configuration does not work
5 participants