-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(username_regex): cp consumer name regx different with dp #2232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2232 +/- ##
==========================================
- Coverage 68.07% 68.02% -0.06%
==========================================
Files 127 127
Lines 3352 3359 +7
Branches 824 826 +2
==========================================
+ Hits 2282 2285 +3
- Misses 1070 1074 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @okaybase |
the tip message is updated~ |
thanks |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
APISIX support consumer name start with number, but APISIX-Dashboard does't support. Does the APISIX-Dashboard need to support consumer that start with number.
And there is the APISIX regex https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L693
After change:
Related issues
fix/resolve #2196
Checklist: