Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(username_regex): cp consumer name regx different with dp #2232

Merged
merged 3 commits into from
Dec 3, 2021
Merged

fix(username_regex): cp consumer name regx different with dp #2232

merged 3 commits into from
Dec 3, 2021

Conversation

zaunist
Copy link
Contributor

@zaunist zaunist commented Dec 2, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

APISIX support consumer name start with number, but APISIX-Dashboard does't support. Does the APISIX-Dashboard need to support consumer that start with number.
And there is the APISIX regex https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L693

image

After change:

QQ20211202-100229@2x

Related issues

fix/resolve #2196

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@zaunist
Copy link
Contributor Author

zaunist commented Dec 2, 2021

@zaunist zaunist marked this pull request as ready for review December 2, 2021 02:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #2232 (4a994e9) into master (cc1e5d4) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
- Coverage   68.07%   68.02%   -0.06%     
==========================================
  Files         127      127              
  Lines        3352     3359       +7     
  Branches      824      826       +2     
==========================================
+ Hits         2282     2285       +3     
- Misses       1070     1074       +4     
Flag Coverage Δ
frontend-e2e-test 68.02% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Consumer/components/Step1.tsx 100.00% <ø> (ø)
...pages/Route/components/Step1/MatchingRulesView.tsx 74.73% <0.00%> (-2.19%) ⬇️
web/src/pages/Route/transform.ts 77.41% <0.00%> (-1.27%) ⬇️
web/src/helpers.tsx 73.77% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1e5d4...4a994e9. Read the comment docs.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zaunist
Copy link
Contributor Author

zaunist commented Dec 3, 2021

cc @okaybase

@okaybase
Copy link
Member

okaybase commented Dec 3, 2021

cc @okaybase

the tip message is updated~

@zaunist
Copy link
Contributor Author

zaunist commented Dec 3, 2021

cc @okaybase

the tip message is updated~

thanks

@okaybase okaybase self-requested a review December 3, 2021 03:10
@juzhiyuan juzhiyuan merged commit c613573 into apache:master Dec 3, 2021
@zaunist zaunist deleted the fix/consumer_name_regx branch December 3, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can not open consumer with numbers as name
5 participants