chore: Create route form optimization #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oil-oil
changed the title
|
It's better to add some test cases cover this change. And need to wait all cases passed. |
OK, I'm fixing some test related issues.🧐 |
Codecov Report
@@ Coverage Diff @@
## master #2336 +/- ##
==========================================
+ Coverage 68.10% 68.12% +0.01%
==========================================
Files 127 127
Lines 3374 3379 +5
Branches 830 832 +2
==========================================
+ Hits 2298 2302 +4
- Misses 1076 1077 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@guoqqqi PTAL |
bzp2010
approved these changes
Feb 27, 2022
juzhiyuan
approved these changes
Feb 27, 2022
1502shivam-singh
approved these changes
Feb 28, 2022
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Mar 13, 2022
* origin: chore: Create route form optimization (apache#2336) fix: add rejected_msg field to limit-count plugin form (apache#2328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
When Service is selected in the form in step 1:
The Upstream selector will select "None" by default in the form in step 2:
When Service is not selected in the form in step 1:
Related issues
resolve #2167
Checklist: