Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a judgement for last_report_time #2551

Merged

Conversation

oil-oil
Copy link
Contributor

@oil-oil oil-oil commented Jul 29, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix #2499

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #2551 (50e3985) into master (0b98833) will decrease coverage by 1.79%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2551      +/-   ##
==========================================
- Coverage   70.37%   68.58%   -1.80%     
==========================================
  Files         194      133      -61     
  Lines        7476     3501    -3975     
  Branches      861      861              
==========================================
- Hits         5261     2401    -2860     
+ Misses       1923     1100     -823     
+ Partials      292        0     -292     
Flag Coverage Δ
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 68.58% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/Upstream/components/UpstreamSelector.tsx 85.71% <0.00%> (-14.29%) ⬇️
.../internal/handler/authentication/authentication.go
api/main.go
api/internal/filter/request_id.go
api/internal/core/entity/format.go
api/internal/core/entity/entity.go
api/internal/utils/consts/api_error.go
api/internal/core/store/store_mock.go
api/internal/filter/recover.go
api/internal/handler/tool/tool.go
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@guoqqqi guoqqqi merged commit 06a7118 into apache:master Jul 29, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Sep 10, 2022
* upstream/master: (23 commits)
  feat: Add config struct of OpenID-Connect Login (apache#2597)
  feat: set serverUrlMap with env, update cypress, update stylelint (apache#2583)
  chore: fix function name typo (apache#2599)
  fix: page refresh causes deletion exception (apache#2593)
  feat: support show all enable plugin list tab (apache#2585)
  fix: drawer components delete plugin not working (apache#2573)
  feat: add batch delete function for route (apache#2502)
  test: reduce fe ci time (apache#2557)
  doc(csp): add correct csp rule (apache#2548)
  doc: add a notice about the compatibility of Ingress and Dashboard (apache#2552)
  fix: add judgement for last_report_time (apache#2551)
  fix: cli test invalid etcd (apache#2544)
  feat: fix actions version to root version (apache#2521)
  fix: duplicate ID (apache#2501)
  fix: block arbitrary file index (apache#2497)
  docs: update deploy-with-docker.md (apache#2472)
  feat: translating Turkish for new features (apache#2487)
  docs: add new import and export docs to sidebar (apache#2485)
  docs: add data loader and new OpenAPI 3 loader (apache#2484)
  feat: support data loader in frontend (apache#2480)
  ...

# Conflicts:
#	api/internal/route.go
#	web/config/defaultSettings.ts
#	web/yarn.lock
bzp2010 pushed a commit to bzp2010/apisix-dashboard that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The last_report_time attribute in the system information of apisix-dashboard is Invalid date
5 participants