Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a unit test for consumer and remove implicit init #844

Closed
wants to merge 0 commits into from
Closed

feat: add a unit test for consumer and remove implicit init #844

wants to merge 0 commits into from

Conversation

ShiningRush
Copy link
Contributor

  • add a real unit test for consumer Get
  • remove implicit init function, go is not recommended.

@nic-chen
Copy link
Member

Good job.Thanks.

We need to enable CI for v2.1 to test.

@nic-chen nic-chen changed the base branch from v2.1 to master November 23, 2020 06:31
@nic-chen nic-chen changed the base branch from master to v2.1 November 23, 2020 06:32
@nic-chen
Copy link
Member

@ShiningRush

please change base to master

@juzhiyuan juzhiyuan changed the base branch from v2.1 to master November 23, 2020 08:40
@juzhiyuan juzhiyuan changed the base branch from master to v2.1 November 23, 2020 08:41
@juzhiyuan
Copy link
Member

It seems that there have a lot of changes with the master branch, maybe related to squash?

@juzhiyuan juzhiyuan changed the base branch from v2.1 to master November 23, 2020 11:20
@juzhiyuan juzhiyuan changed the base branch from master to v2.1 November 23, 2020 11:20
@juzhiyuan
Copy link
Member

emmm may need cherry-pick

@ShiningRush ShiningRush deleted the v2.1 branch November 23, 2020 11:54
@ShiningRush
Copy link
Contributor Author

I open a new PR(#859 ) for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-chen nic-chen Awaiting requested review from nic-chen

@juzhiyuan juzhiyuan Awaiting requested review from juzhiyuan

@liuxiran liuxiran Awaiting requested review from liuxiran

@tokers tokers Awaiting requested review from tokers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShiningRush @nic-chen @juzhiyuan