Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make field ID compatible with both string and int #902

Merged
merged 8 commits into from
Nov 30, 2020

Conversation

nic-chen
Copy link
Member

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Related issues

close #896

@codecov-io
Copy link

codecov-io commented Nov 28, 2020

Codecov Report

Merging #902 (c7b848b) into master (478cbeb) will decrease coverage by 0.13%.
The diff coverage is 25.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
- Coverage   42.95%   42.82%   -0.14%     
==========================================
  Files          18       18              
  Lines        1271     1289      +18     
==========================================
+ Hits          546      552       +6     
- Misses        633      645      +12     
  Partials       92       92              
Impacted Files Coverage Δ
api/internal/core/entity/entity.go 0.00% <0.00%> (ø)
api/internal/core/entity/query.go 0.00% <0.00%> (ø)
api/internal/core/store/storehub.go 0.00% <0.00%> (ø)
api/internal/handler/consumer/consumer.go 34.92% <0.00%> (ø)
api/internal/handler/service/service.go 27.65% <0.00%> (-0.61%) ⬇️
api/internal/utils/utils.go 51.61% <0.00%> (-7.65%) ⬇️
api/internal/handler/route/route.go 46.56% <44.44%> (+0.11%) ⬆️
api/internal/core/store/store.go 79.22% <100.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478cbeb...c7b848b. Read the comment docs.

@membphis
Copy link
Member

api/test/e2e/id_compatible_test.go looks good for me. I think we can turn this PR to ready @nic-chen

@nic-chen nic-chen marked this pull request as ready for review November 29, 2020 06:24
@membphis
Copy link
Member

api/test/e2e/id_compatible_test.go looks good for me

for the source code, need @gxthrj @ShiningRush @tokers @spacewander help ^_^

Copy link
Contributor

@gxthrj gxthrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nic-chen
Copy link
Member Author

@ShiningRush @tokers @spacewander
please have a look, thanks.

@tokers
Copy link
Contributor

tokers commented Nov 30, 2020

LGTM

@nic-chen nic-chen merged commit b48ef0a into apache:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: manager api does not support int for field id
7 participants