feat: support more APISIX features #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao Zhang <tokers@apache.org>
Signed-off-by: Chao Zhang <tokers@apache.org>
tao12345666333
requested review from
tao12345666333,
gxthrj and
lingsamuel
and removed request for
tao12345666333
charts/apisix/values.yaml
Outdated
| @@ -186,6 +188,8 @@ stream_plugins: | |||
| - ip-restriction | |||
| - limit-conn | |||
|
|
|||
| pluginAttrs: null | |||
There was a problem hiding this comment.
Its type should be array, right?
There was a problem hiding this comment.
It's a map, let me to change to {}.
lingsamuel
approved these changes
Nov 8, 2021
tao12345666333
approved these changes
Nov 8, 2021
|
Please also update the document to introduce these configuration items, and then we can merge. |
Signed-off-by: Chao Zhang <tokers@apache.org>
Added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds some new features for the apisix charts, so that more and more APISIX features can be used.
Signed-off-by: Chao Zhang tokers@apache.org