Ingress classname #254
Merged
Ingress classname #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokers
reviewed
Mar 20, 2022
tao12345666333
requested changes
Mar 20, 2022
tokers
approved these changes
Mar 22, 2022
charts/apisix-dashboard/values.yaml
Outdated
| @@ -86,9 +86,17 @@ service: | |||
|
|
|||
| ingress: | |||
| enabled: false | |||
| # kubernetes ingress attribe ingressClassName,default to "apisix" | |||
| # Kubernetes 1.18+ support ingressClassName attribe | |||
| className: "apisix" | |||
There was a problem hiding this comment.
We should comment it by default
There was a problem hiding this comment.
why? is become kubernetes version not upgrade!?
There was a problem hiding this comment.
Yes, we need to maintain compatibility.
update ingress attribeute `hosts` example
ingress.className remove default value
tao12345666333
approved these changes
Mar 22, 2022
del notes space
tao12345666333
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ingress on high version，can ingressClassName attribe