feat: allow to configure gateway.resources #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revolyssup
approved these changes
Jan 16, 2024
|
please fix ci |
mstefany
force-pushed
the
gateway.resources
branch
from
38cd551
to
28a3402
Compare
AlinsRan
approved these changes
Jan 17, 2024
|
@Revolyssup the ci has passed. Shall we merge this pr? |
Revolyssup
approved these changes
Jan 21, 2024
|
@mstefany looks like there are few merge conflicts |
mstefany
force-pushed
the
gateway.resources
branch
from
28a3402
to
bec3816
Compare
|
@Revolyssup conflict is resolved, there was a collision with recently merged securityContext PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
gatewaydeployment is enabled, then theapisixgateway container in the pod is deployed without any resource requests or limits, and they are not even configurable. This PR tries to make them configurable.