Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support adding annotations to Deployment #697

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

mstefany
Copy link
Contributor

Allowing to add annotations for Deployment object of apisix-ingress-controller makes usage of 3rd party tools like reloader possible, e.g.:

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    meta.helm.sh/release-name: ingress-apisix
    meta.helm.sh/release-namespace: ingress-apisix
    reloader.stakater.com/auto: "true"
[...]

Use case: We are delivering admin key to Kubernetes using external-secrets-operator and then passing into apisix via environment variable, and we want ingress controllers to be automatically reloaded when update of secret happens. For this purpose, we need to be able to add reloader annotation to the deployment object.

@AlinsRan AlinsRan merged commit 54f67da into apache:master Jan 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants