fix: enable gateway sidecar only when replicasCount of controller is 1 #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fengxusong <fengxsong@outlook.com>
fengxsong
force-pushed
the
fix_ingress_controller_with_gateway
branch
from
a1f9aac
to
1e07725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the ingress-controller, we usually scale the replicas to more than 1 to ensure HA. but in experimental mode which start the built-in etcd grpcserver, as all the controllers had enabled leader election, then only one of then can actually serve grpc requests from APISIX gateway. In another words, only the gateway that live with the working ingress-controller can process requests from clients.
This PR restricts gateway related manifests to be rendered only when the
replicasCount=1andgateway.enabled=true.changes in the
charts/apisix/templates/configmap.yamlallow us to test this feature without too much modifications.