feat: add enable_server_tokens option #727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mstefany Can you address the lint issue? |
|
@Revolyssup Should be fixed now, please, review the code and provide feedback or approve. |
Revolyssup
approved these changes
Mar 20, 2024
AlinsRan
reviewed
Mar 21, 2024
| @@ -41,6 +41,9 @@ data: | |||
| apisix: | |||
| enable_control: true | |||
| enable_reuseport: true | |||
| {{- if and (not (eq .Values.gateway.enableServerTokens nil)) (hasKey .Values.gateway "enableServerTokens") }} | |||
There was a problem hiding this comment.
Should it be like this?
#values.yaml
enableServerTokens: true # apisix-configmap.yaml
enable_server_tokens: {{ .Values.gateway.enableServerTokens }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APISIX/nginx server tokens are enabled by default, and leak APISIX version is form of a header -
Server: APISIX/3.8.0. Add option to allow to disable version leak, turning header intoServer: APISIX(full removal of the header is probably possible only using header-manipulating plugins).