Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable proxy-protocol configuration nodes #756

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heresie
Copy link
Contributor

@heresie heresie commented May 16, 2024

Hello everybody 馃憢馃徎

I contributed in june 2023 to this project by adding configuration nodes in helm chart allowing clean proxy-protocol configuration (#528).

Recently we wanted to upgrade our current APISIX release because of CVE-2024-32638 but during upgrade we noticed that all proxy-protocol configuration nodes have disapeared since this PR : #738

Currently, we are unable to upgrade APISIX without manually editing ConfigMaps to re-enable proxy-protocol, and that's a big problem because we cannot automatize our deployments. I think we are not alone in this case (for example @adussarps in #748).

Can you consider my PR that re-introduce needed changes ?

Here are example values for testing purpose :

global:
  enableIPv6: false
  storageClass: <my-storage-class>

apisix:
  kind: DaemonSet
  ssl:
    enabled: true
  proxyProtocol:
    enabled: true
    listenHttpPort: 9181
    listenHttpsPort: 9182

service:
  type: NodePort
  http:
    enabled: true
  proxyProtocol:
    http:
      enabled: true
      nodePort: 30080
      containerPort: 9181
    https:
      enabled: true
      nodePort: 30443
      containerPort: 9182

This PR also bumps Chart Version to the next minor : 2.8.0.

All comments are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant