feat: re-enable proxy-protocol configuration nodes #756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everybody 馃憢馃徎
I contributed in june 2023 to this project by adding configuration nodes in helm chart allowing clean proxy-protocol configuration (#528).
Recently we wanted to upgrade our current APISIX release because of CVE-2024-32638 but during upgrade we noticed that all proxy-protocol configuration nodes have disapeared since this PR : #738
Currently, we are unable to upgrade APISIX without manually editing ConfigMaps to re-enable proxy-protocol, and that's a big problem because we cannot automatize our deployments. I think we are not alone in this case (for example @adussarps in #748).
Can you consider my PR that re-introduce needed changes ?
Here are example values for testing purpose :
This PR also bumps Chart Version to the next minor : 2.8.0.
All comments are welcome.