fix: timer leak memory (#591)

Co-authored-by: Leon <yuanfeng0905@haituncun.com>
apache · Aug 4, 2021 · 5635652 · 5635652
1 parent 812e4bd
commit 5635652
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/ingress/controller.go b/pkg/ingress/controller.go
@@ -601,11 +601,13 @@ func (c *Controller) syncUpstreamNodesChangeToCluster(ctx context.Context, clust
 
 func (c *Controller) checkClusterHealth(ctx context.Context, cancelFunc context.CancelFunc) {
 	defer cancelFunc()
+	t := time.NewTicker(5 * time.Second)
+	defer t.Stop()
 	for {
 		select {
 		case <-ctx.Done():
 			return
-		case <-time.After(5 * time.Second):
+		case <-t.C:
 		}
 
 		err := c.apisix.Cluster(c.cfg.APISIX.DefaultClusterName).HealthCheck(ctx)