Skip to content

Commit

Permalink
fix: ingress.tls secret not found (#1394)
Browse files Browse the repository at this point in the history
  • Loading branch information
shareinto committed Dec 12, 2022
1 parent 7e8f076 commit 8cf79c2
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 4 deletions.
16 changes: 14 additions & 2 deletions pkg/providers/ingress/ingress.go
Expand Up @@ -53,6 +53,10 @@ type ingressController struct {
ingressLister kube.IngressLister
ingressInformer cache.SharedIndexInformer

secretInformer cache.SharedIndexInformer
endpointInformer cache.SharedIndexInformer
serviceInformer cache.SharedIndexInformer

// secretSSLMap stores reference from K8s secret to Ingress
// type: Map<SecretKey, Map<IngressVersionKey, SSL in APISIX>>
// SecretKey -> IngressVersionKey -> []string
Expand All @@ -61,7 +65,7 @@ type ingressController struct {
secretSSLMap *sync.Map
}

func newIngressController(common *ingressCommon, ingressLister kube.IngressLister, ingressInformer cache.SharedIndexInformer) *ingressController {
func newIngressController(common *ingressCommon, ingressLister kube.IngressLister, ingressInformer, secretInformer, endpointInformer, serviceInformer cache.SharedIndexInformer) *ingressController {
c := &ingressController{
ingressCommon: common,

Expand All @@ -71,6 +75,10 @@ func newIngressController(common *ingressCommon, ingressLister kube.IngressListe
ingressLister: ingressLister,
ingressInformer: ingressInformer,

secretInformer: secretInformer,
endpointInformer: endpointInformer,
serviceInformer: serviceInformer,

secretSSLMap: new(sync.Map),
}

Expand All @@ -87,7 +95,11 @@ func (c *ingressController) run(ctx context.Context) {
defer log.Infof("ingress controller exited")
defer c.workqueue.ShutDown()

if !cache.WaitForCacheSync(ctx.Done(), c.ingressInformer.HasSynced) {
if !cache.WaitForCacheSync(ctx.Done(),
c.ingressInformer.HasSynced,
c.secretInformer.HasSynced,
c.serviceInformer.HasSynced,
c.endpointInformer.HasSynced) {
log.Errorf("cache sync failed")
return
}
Expand Down
12 changes: 10 additions & 2 deletions pkg/providers/ingress/provider.go
Expand Up @@ -59,7 +59,10 @@ type ingressProvider struct {

ingressController *ingressController

ingressInformer cache.SharedIndexInformer
ingressInformer cache.SharedIndexInformer
serviceInformer cache.SharedIndexInformer
endpointInformer cache.SharedIndexInformer
secretInformer cache.SharedIndexInformer
}

func NewProvider(common *providertypes.Common, namespaceProvider namespace.WatchingNamespaceProvider,
Expand All @@ -77,6 +80,11 @@ func NewProvider(common *providertypes.Common, namespaceProvider namespace.Watch
default:
p.ingressInformer = kubeFactory.Extensions().V1beta1().Ingresses().Informer()
}

p.endpointInformer = common.EpInformer
p.serviceInformer = common.SvcInformer
p.secretInformer = common.SecretInformer

ingressLister := kube.NewIngressLister(
kubeFactory.Networking().V1().Ingresses().Lister(),
kubeFactory.Networking().V1beta1().Ingresses().Lister(),
Expand All @@ -93,7 +101,7 @@ func NewProvider(common *providertypes.Common, namespaceProvider namespace.Watch
}, translator, apisixTranslator),
}

p.ingressController = newIngressController(c, ingressLister, p.ingressInformer)
p.ingressController = newIngressController(c, ingressLister, p.ingressInformer, p.secretInformer, p.endpointInformer, p.serviceInformer)

return p, nil
}
Expand Down

0 comments on commit 8cf79c2

Please sign in to comment.