Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve make update-all #1547

Closed
tao12345666333 opened this issue Dec 20, 2022 · 2 comments · Fixed by #1500
Closed

chore: improve make update-all #1547

tao12345666333 opened this issue Dec 20, 2022 · 2 comments · Fixed by #1500
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tao12345666333
Copy link
Member

tao12345666333 commented Dec 20, 2022 •
edited
Loading

make update-all should not modify the CHANGELOG file. It is automatically generated by release-tools
@tao12345666333 tao12345666333 added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 20, 2022
@Gallardot
Copy link
Member

Hi @tao12345666333

I think this issue has been fixed in this PR. #1500

But I found another issue, that is, make update-all will execute update-gofmt to fix the imports issue, but the current github CI doesn't check this. So I create a PR to fix it. #1606

@tao12345666333
Copy link
Member Author

Great! I will close this one

@tao12345666333 tao12345666333 linked a pull request Jan 19, 2023 that will close this issue
feat: support for specifying port in external services #1500
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support for specifying port in external services Gallardot/apisix-ingress-controller
2 participants
@Gallardot @tao12345666333