Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add goimports-reviser #1606

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Conversation

Gallardot
Copy link
Member

Signed-off-by: Gallardot tttick@163.com

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Gallardot <tttick@163.com>
Signed-off-by: Gallardot <tttick@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #1606 (a0678b6) into master (31714eb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1606   +/-   ##
=======================================
  Coverage   41.30%   41.30%           
=======================================
  Files          87       87           
  Lines        7460     7460           
=======================================
  Hits         3081     3081           
  Misses       4026     4026           
  Partials      353      353           
Impacted Files Coverage Δ
...ess/translation/annotations/plugins/http_method.go 81.81% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Gallardot <tttick@163.com>
@Gallardot Gallardot marked this pull request as ready for review January 19, 2023 06:39
@tao12345666333 tao12345666333 added CI triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 19, 2023
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone Jan 19, 2023
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 9aae0e3 into apache:master Jan 29, 2023
@Gallardot Gallardot deleted the goimports-reviser branch January 30, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants