Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request help: run e2e test in existed cluster #481

Closed
lingsamuel opened this issue May 24, 2021 · 5 comments · Fixed by #896
Closed

request help: run e2e test in existed cluster #481

lingsamuel opened this issue May 24, 2021 · 5 comments · Fixed by #896
Labels
CI help wanted Extra attention is needed

Comments

@lingsamuel
Copy link
Member

Issue description

Run e2e in existed cluster. Current e2e requires docker registry at localhost:5000.

@tokers
Copy link
Contributor

tokers commented May 24, 2021

I am wondering whether this is really necessary as the overheads to create a kind cluster is trivial.

cc @tao12345666333

@tao12345666333
Copy link
Member

I agree with @tokers

But if you don't want to do this, we can simply modify our script.

By load image instead of downloading from a local registry.

@tokers
Copy link
Contributor

tokers commented May 25, 2021

I agree with @tokers

But if you don't want to do this, we can simply modify our script.

By load image instead of downloading from a local registry.

Maybe add some makefile directives like "push-images-to-kind", "push-images-to-minikube" and blah blah blah.

@tao12345666333
Copy link
Member

ref: #880

@tao12345666333 tao12345666333 added help wanted Extra attention is needed CI labels Mar 4, 2022
@lingsamuel
Copy link
Member Author

Resolved by #896

@tao12345666333 tao12345666333 linked a pull request Mar 8, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants