Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom registry for e2e test #896

Merged
merged 7 commits into from
Mar 8, 2022

Conversation

Belyenochi
Copy link
Contributor

@Belyenochi Belyenochi commented Mar 2, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

resolves #880

@tao12345666333 tao12345666333 requested review from tao12345666333, tokers and lingsamuel and removed request for tao12345666333 and tokers March 2, 2022 09:30
@tao12345666333
Copy link
Member

Thanks! it's on my list.

I will review it ASAP.

Makefile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #896 (7173ed6) into master (e2475cf) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   32.01%   32.02%           
=======================================
  Files          70       71    +1     
  Lines        7749     7772   +23     
=======================================
+ Hits         2481     2489    +8     
- Misses       4993     5009   +16     
+ Partials      275      274    -1     
Impacted Files Coverage Δ
pkg/apisix/cluster.go 31.88% <0.00%> (-0.70%) ⬇️
pkg/ingress/endpoint.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/apisix/noop.go 0.00% <0.00%> (ø)
pkg/apisix/stream_route.go 36.42% <0.00%> (+0.12%) ⬆️
pkg/kube/translation/apisix_route.go 22.43% <0.00%> (+0.60%) ⬆️
pkg/ingress/pod.go 37.34% <0.00%> (+2.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2475cf...7173ed6. Read the comment docs.

Copy link
Member

@lingsamuel lingsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We don't need to change CI config since it starts kind directly https://github.com/apache/apisix-ingress-controller/blob/master/.github/workflows/e2e-test-ci.yml#L89

Makefile Outdated Show resolved Hide resolved
@lingsamuel lingsamuel merged commit f84a083 into apache:master Mar 8, 2022
@lingsamuel
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: custom registry request help: run e2e test in existed cluster
4 participants