-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom registry for e2e test #896
Conversation
Thanks! it's on my list. I will review it ASAP. |
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
=======================================
Coverage 32.01% 32.02%
=======================================
Files 70 71 +1
Lines 7749 7772 +23
=======================================
+ Hits 2481 2489 +8
- Misses 4993 5009 +16
+ Partials 275 274 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We don't need to change CI config since it starts kind directly https://github.com/apache/apisix-ingress-controller/blob/master/.github/workflows/e2e-test-ci.yml#L89
Thanks! |
Type of change:
What this PR does / why we need it:
resolves #880