Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: change the module from github.com/api7/ingress-controller to github.com/apache/apisix-ingress-controller #67

Closed
gxthrj opened this issue Dec 8, 2020 · 5 comments · Fixed by #220
Closed

Chore: change the module from github.com/api7/ingress-controller to github.com/apache/apisix-ingress-controller #67

gxthrj opened this issue Dec 8, 2020 · 5 comments · Fixed by #220
Assignees
@Firstsawyou
Labels
good first issue Good for newcomers
Milestone
0.3.0

Comments

@gxthrj
Copy link
Contributor

gxthrj commented Dec 8, 2020

No description provided.

@gxthrj gxthrj added the good first issue Good for newcomers label Dec 8, 2020
@gxthrj gxthrj added this to the 0.1.1 milestone Dec 8, 2020
@Firstsawyou
Copy link
Contributor

This looks very interesting, let me try it. ^ _ ^

@gxthrj gxthrj modified the milestones: 0.2.0, 0.3.0 Jan 4, 2021
@Firstsawyou
Copy link
Contributor

@gxthrj I need to change all github.com/api7/ingress-controller to github.com/apache/apisix-ingress-controller right?

@tokers
Copy link
Contributor

tokers commented Feb 1, 2021

@Firstsawyou Yes, you have to.

@tokers
Copy link
Contributor

tokers commented Feb 1, 2021

Change module name is different from change dependencies, so we cannot use replace.

@Firstsawyou
Copy link
Contributor

Change module name is different from change dependencies, so we cannot use replace.

Got it.

Firstsawyou pushed a commit to Firstsawyou/apisix-ingress-controller that referenced this issue Feb 1, 2021
chore: change the module from github.com/api7/ingress-controller to…
6f0bbd6 
… `github.com/apache/apisix-ingress-controller`

close apache#67
@Firstsawyou Firstsawyou mentioned this issue Feb 1, 2021
Merged
4 tasks
gxthrj pushed a commit that referenced this issue Feb 2, 2021
@Firstsawyou
chore: change the module from github.com/api7/ingress-controller to…
ae48fa3 
… `github.com/apache/apisix-ingress-controller` (#220)

close #67

Co-authored-by: lin <lin@MBPro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Firstsawyou Firstsawyou

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.3.0
3 participants
@gxthrj @tokers @Firstsawyou