Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify metrics name apisix_bad_status_codes to apisix_status_codes #1012

Merged
merged 1 commit into from
May 11, 2022
Merged

feat: modify metrics name apisix_bad_status_codes to apisix_status_codes #1012

merged 1 commit into from
May 11, 2022

Conversation

greenhandatsjtu
Copy link
Contributor

@greenhandatsjtu greenhandatsjtu commented May 10, 2022 •
edited

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Fix: #1005
rename metrics apisix_bad_status_codes to apisix_status_codes, as all the status codes are recorded here.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333 tao12345666333 added changelog Issues with this label should be added to changelog when public a new release area/controller labels May 11, 2022
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone May 11, 2022
tao12345666333
tao12345666333 approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks!

juzhiyuan
juzhiyuan approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much clearer and semantic

@tao12345666333 tao12345666333 merged commit 3a175e5 into apache:master May 11, 2022
@lijing-21
Copy link

Hi @greenhandatsjtu , thanks for the contribution!

Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)

[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt

@Sindweller Sindweller mentioned this pull request Aug 22, 2022
Closed
8 tasks
@tao12345666333 tao12345666333 mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@lingsamuel lingsamuel Awaiting requested review from lingsamuel

@bzp2010 bzp2010 Awaiting requested review from bzp2010

@nic-6443 nic-6443 Awaiting requested review from nic-6443

Assignees
No one assigned
Labels
area/controller changelog Issues with this label should be added to changelog when public a new release
Projects
Apache APISIX Ingress controller
Status: Done
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Suggestion: Modify the metrics name
4 participants
@greenhandatsjtu @lijing-21 @juzhiyuan @tao12345666333