Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add csrf plugin annotation in ingress resource #1023

Merged
merged 4 commits into from
May 26, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented May 18, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #1023 (a55bcb5) into master (3cccd56) will increase coverage by 0.09%.
The diff coverage is 48.83%.

❗ Current head a55bcb5 differs from pull request most recent head 74eb3aa. Consider uploading reports for the commit 74eb3aa to get more accurate results

@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   30.87%   30.96%   +0.09%     
==========================================
  Files          74       75       +1     
  Lines        8373     8416      +43     
==========================================
+ Hits         2585     2606      +21     
- Misses       5511     5532      +21     
- Partials      277      278       +1     
Impacted Files Coverage Δ
pkg/kube/translation/annotations.go 61.53% <ø> (ø)
pkg/kube/translation/annotations/csrf.go 0.00% <0.00%> (ø)
pkg/kube/translation/apisix_route.go 20.87% <0.00%> (-0.28%) ⬇️
pkg/kube/translation/apisix_consumer.go 69.23% <60.00%> (-2.20%) ⬇️
pkg/kube/translation/plugin.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cccd56...74eb3aa. Read the comment docs.

@AlinsRan AlinsRan marked this pull request as ready for review May 18, 2022 07:15
pkg/kube/translation/annotations/csrf.go Outdated Show resolved Hide resolved
pkg/types/apisix/v1/plugin_types.go Outdated Show resolved Hide resolved
@AlinsRan AlinsRan requested a review from tokers May 25, 2022 02:36
@tao12345666333 tao12345666333 added the enhancement New feature or request label May 25, 2022
@tao12345666333 tao12345666333 self-assigned this May 25, 2022
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lingsamuel lingsamuel changed the title feat: add csrf plugin annotation in ingress resourece. feat: add csrf plugin annotation in ingress resource May 26, 2022
@tao12345666333 tao12345666333 merged commit 25daa6e into apache:master May 26, 2022
@AlinsRan AlinsRan deleted the feat/annotation/csrf branch June 9, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants