Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update contribute.md doc #1036

Merged
merged 3 commits into from
May 25, 2022
Merged

doc: update contribute.md doc #1036

merged 3 commits into from
May 25, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented May 23, 2022 •
edited

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

What did you do:

  • Fixed push-images error.
  • More detailed local development process.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@AlinsRan AlinsRan marked this pull request as draft May 23, 2022 09:45
@AlinsRan AlinsRan marked this pull request as ready for review May 23, 2022 10:03
tao12345666333
tao12345666333 reviewed May 24, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the markdown format error.
Thanks

tao12345666333
tao12345666333 approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 49dd015 into apache:master May 25, 2022
lingsamuel pushed a commit to lingsamuel/apisix-ingress-controller that referenced this pull request May 26, 2022
@AlinsRan @lingsamuel
doc: update contribute.md doc (apache#1036)
30397c2
@AlinsRan AlinsRan deleted the doc/contribute branch June 9, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlinsRan @tao12345666333 @tokers