Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gateway API HTTPRoute #1037

Merged
merged 9 commits into from
May 31, 2022

Conversation

lingsamuel
Copy link
Member

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Type of change:

  • New feature provided

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@tao12345666333 tao12345666333 self-requested a review May 25, 2022 07:46
var weightedUpstreams []apisixv1.TrafficSplitConfigRuleWeightedUpstream

for j, backend := range backends {
//TODO: Support filters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can implement some basic proxy capabilities first, and other extension capabilities can be placed in subsequent PRs

@lingsamuel lingsamuel marked this pull request as ready for review May 26, 2022 07:49
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #1037 (9f840a4) into master (5477fb0) will increase coverage by 0.07%.
The diff coverage is 33.45%.

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
+ Coverage   30.97%   31.04%   +0.07%     
==========================================
  Files          75       77       +2     
  Lines        8792     9070     +278     
==========================================
+ Hits         2723     2816      +93     
- Misses       5775     5951     +176     
- Partials      294      303       +9     
Impacted Files Coverage Δ
pkg/ingress/controller.go 0.86% <0.00%> (-0.02%) ⬇️
pkg/ingress/gateway_httproute.go 0.00% <0.00%> (ø)
pkg/kube/translation/translator.go 46.07% <ø> (ø)
pkg/types/event.go 100.00% <ø> (ø)
pkg/kube/translation/gateway_httproute.go 67.39% <67.39%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5477fb0...9f840a4. Read the comment docs.

@tao12345666333
Copy link
Member

re-run all jobs.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move forward.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants