e2e-test: upgrade to ginkgo v2 #1046
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
=======================================
Coverage 30.97% 30.97%
=======================================
Files 75 75
Lines 8792 8792
=======================================
Hits 2723 2723
Misses 5775 5775
Partials 294 294 Continue to review full report at Codecov.
|
|
re-run all jobs |
| @@ -8,7 +8,7 @@ require ( | |||
| github.com/gavv/httpexpect/v2 v2.2.0 | |||
| github.com/gorilla/websocket v1.4.2 | |||
| github.com/gruntwork-io/terratest v0.32.8 | |||
| github.com/onsi/ginkgo v1.16.4 | |||
| github.com/onsi/ginkgo/v2 v2.1.4 | |||
There was a problem hiding this comment.
Can we use replace directive so that we can avoid a lot of changes?
There was a problem hiding this comment.
I don't think replace is the best practice for the gomod.
And if we use replace, it may lead to some confusion in the source code.
There was a problem hiding this comment.
I use an alias on the import, so it has already avoid as more changes as we can.
There was a problem hiding this comment.
I agree with @fatpa
I hope this project can be more clear, and there are not many changes, which have been done in this PR.
| @@ -542,13 +543,18 @@ github.com/onsi/ginkgo v1.12.1/go.mod h1:zj2OWP4+oCPe1qIXoGWkgMRwljMUYCdkwsT2108 | |||
| github.com/onsi/ginkgo v1.14.0/go.mod h1:iSB4RoI2tjJc9BBv4NKIKWKya62Rps+oPG/Lv9klQyY= | |||
There was a problem hiding this comment.
we cloud clean older version, right?
There was a problem hiding this comment.
We can't.
I try to remove it from the go.sum, but after re-running go mod tidy, it will come back again.
|
Still has some unknown failure checks. Maybe due to the resource lack of the e2e test environment? |
|
Thanks |
Type of change:
What this PR does / why we need it:
#1041
Pre-submission checklist: