e2e: gateway api httproute #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
lingsamuel
force-pushed
the
e2e-gateway-api-httproute
branch
from
735967d
to
1a64800
Compare
|
re-run all jobs |
Codecov Report
@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
- Coverage 30.83% 30.81% -0.02%
==========================================
Files 77 77
Lines 9140 9174 +34
==========================================
+ Hits 2818 2827 +9
- Misses 6019 6038 +19
- Partials 303 309 +6
Continue to review full report at Codecov.
|
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
| @@ -0,0 +1,3 @@ | |||
| # Gateway API CRDs: | |||
| # https://github.com/kubernetes-sigs/gateway-api/tree/66a7c8ffc942a90294612f63c6dedcc73a3de5ca/config/crd/stable | |||
| samples/deploy/gateway-api/* linguist-generated=true | |||
There was a problem hiding this comment.
good job! I like this configuration item
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
tao12345666333
approved these changes
Jun 8, 2022
tokers
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com
Type of change:
Also fix some bugs in the previous PR.