-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add v2 ApisixRoute reference #1068
Conversation
Can you help to add the v2 documentation for the other resources as well? |
Sure. Sorry for missing the other resources. |
Don't worry, ping me if you need any help |
Hi @tao12345666333 , I have a question about our CRD version 2. |
@stillfox-lee If you pull the latest code from the master branch, you will see the CRD configuration of ApisixPluginConfig v2. For ApisixUpstream, it can be ignored because we haven't added the v2 implementation yet. until #944 merged |
Got it, thx. |
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
=======================================
Coverage 30.83% 30.83%
=======================================
Files 77 77
Lines 9140 9140
=======================================
Hits 2818 2818
Misses 6019 6019
Partials 303 303 Continue to review full report at Codecov.
|
I can merge the commit records for you later, so that files unrelated to your changes will not appear in the review list |
Oh, I see. Sorry about that. I'm not familiar with PR workflow. I should just merge upstream to my origin and then commit to the origin branch. |
1 similar comment
Oh, I see. Sorry about that. I'm not familiar with PR workflow. I should just merge upstream to my origin and then commit to the origin branch. |
5446e8b
to
e0ec736
Compare
Sorry for delay. I have updated the commit records in this PR. |
@stillfox-lee could you please update the index? Just add all of these filenames apisix-ingress-controller/docs/en/latest/config.json Lines 35 to 42 in 50d6026
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The titles of these files also need to be updated, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change:
What this PR does / why we need it:
issue
I just copy from api_route_v2beta3.md. And add some new rows that already exist in
apisix-ingress-controller/samples/deploy/crd/v1/ApisixRoute.yaml
Line 563 in d3a823f
Pre-submission checklist: