Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct typo & link #1073

Merged
merged 2 commits into from
Jun 9, 2022
Merged

docs: correct typo & link #1073

merged 2 commits into from
Jun 9, 2022

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
docs: correct typo & link
8d9168e 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review June 7, 2022 13:22
@spacewander
Copy link
Member Author

The mtls link to the directory is treated as mtls.md on the website, so I change the link to the GitHub repo.

tao12345666333
tao12345666333 reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a suggestion, others LGTM

docs/en/latest/design.md Outdated Show resolved Hide resolved
@tao12345666333 tao12345666333 added the documentation Improvements or additions to documentation label Jun 7, 2022
@spacewander @tao12345666333
Update docs/en/latest/design.md
9acbec6 
Co-authored-by: Jintao Zhang <tao12345666333@163.com>
@juzhiyuan juzhiyuan merged commit f0d64b6 into apache:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@tokers tokers Awaiting requested review from tokers

@lingsamuel lingsamuel Awaiting requested review from lingsamuel

@bzp2010 bzp2010 Awaiting requested review from bzp2010

@gxthrj gxthrj Awaiting requested review from gxthrj

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Apache APISIX Ingress controller
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spacewander @juzhiyuan @tao12345666333