Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tag for keyAuth field #1080

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

fengxsong
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

I'm currently doing some work to migrate kong's configuration to apisixroute, when marshaling github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3.ApisixRoute object, the output of keyAuth field is keyauth.
So when I applied the generated manifests to apiserver, action failed because of CRD's Scheme verification.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@tao12345666333
Copy link
Member

test/e2e/suite-features/consumer.go
270:  name: keyauth
274:                    assert.Nil(ginkgo.GinkgoT(), s.CreateResourceFromString(secret), "creating keyauth secret for ApisixConsumer")
275:                    assert.Nil(ginkgo.GinkgoT(), s.ApisixConsumerKeyAuthSecretCreated("keyvalue", "keyauth"), "creating keyAuth ApisixConsumer")

Although it doesn't matter, can you update all of the above together?

@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Jun 9, 2022
@tao12345666333 tao12345666333 merged commit a0b88d1 into apache:master Jun 9, 2022
@tao12345666333
Copy link
Member

let's move forward.

@fengxsong fengxsong deleted the fix_keyAuth_typo branch June 9, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants