Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync CRD and ingress resource to apisix mechanism. #1102

Merged
merged 16 commits into from
Jun 28, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Jun 24, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

Quote:

Resolve: #1099

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #1102 (c73e104) into master (d46b8e0) will decrease coverage by 0.73%.
The diff coverage is 18.44%.

@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
- Coverage   31.84%   31.11%   -0.74%     
==========================================
  Files          78       79       +1     
  Lines        8861     9167     +306     
==========================================
+ Hits         2822     2852      +30     
- Misses       5732     6006     +274     
- Partials      307      309       +2     
Impacted Files Coverage Δ
pkg/apisix/apisix.go 61.36% <ø> (ø)
pkg/ingress/apisix_cluster_config.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_consumer.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_pluginconfig.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_tls.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 0.40% <0.00%> (-0.05%) ⬇️
pkg/ingress/endpoint.go 0.00% <0.00%> (ø)
pkg/ingress/ingress.go 6.16% <0.00%> (-0.39%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f453e80...c73e104. Read the comment docs.

@tao12345666333
Copy link
Member

could you merge latest code? thanks!

@AlinsRan
Copy link
Contributor Author

could you merge latest code? thanks!

Done.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks

@tao12345666333 tao12345666333 merged commit 49991e2 into apache:master Jun 28, 2022
@AlinsRan AlinsRan deleted the feat/sync/apisix branch July 6, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants