Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Makefile verify-mdlint #1126

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

stillfox-lee
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

issue: #1110
Update Makefile's verify-mdlint. Ignore CHANGELOG.md.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #1126 (8fffbd9) into master (0e1f8d4) will not change coverage.
The diff coverage is n/a.

❗ Current head 8fffbd9 differs from pull request most recent head 06c69ca. Consider uploading reports for the commit 06c69ca to get more accurate results

@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   30.38%   30.38%           
=======================================
  Files          81       81           
  Lines        9390     9390           
=======================================
  Hits         2853     2853           
  Misses       6222     6222           
  Partials      315      315           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810f1a1...06c69ca. Read the comment docs.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks!

@lijing-21
Copy link

Hi @stillfox-lee , thanks for the contribution!

Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)

[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve: Keep verify-mdlint same between Makefile and github actions
5 participants