Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e-test: Optimize the runtime of ingress/features, and support more default value in NewScaffold #1128

Merged
merged 6 commits into from
Jul 6, 2022
Merged

e2e-test: Optimize the runtime of ingress/features, and support more default value in NewScaffold #1128

merged 6 commits into from
Jul 6, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Jul 2, 2022 •
edited

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

Resolve comment: #1103
Support: #1127

split suites-ingress:

  • suites-ingress-features
  • suites-ingress-resource

splite suites-feautres/conmsumer.go to suites-plugins-authentication/*

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022 •
edited

Codecov Report

Merging #1128 (378eeb4) into master (4aa2ca5) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   30.34%   30.38%   +0.04%     
==========================================
  Files          81       81              
  Lines        9403     9409       +6     
==========================================
+ Hits         2853     2859       +6     
  Misses       6235     6235              
  Partials      315      315
Impacted Files Coverage Δ
pkg/kube/translation/ingress.go 68.66% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa2ca5...378eeb4. Read the comment docs.

@AlinsRan AlinsRan force-pushed the e2e/fix branch 3 times, most recently from 302b6d1 to 29fe29c Compare July 3, 2022 15:32
@AlinsRan AlinsRan changed the title e2e-test: support more default value in NewScaffold e2e-test: support more default value in NewScaffold and split ingress/feature Jul 4, 2022
@AlinsRan AlinsRan changed the title e2e-test: support more default value in NewScaffold and split ingress/feature e2e-test: support more default value in NewScaffold and split suite-ingress/suite-feature Jul 4, 2022
@AlinsRan AlinsRan changed the title e2e-test: support more default value in NewScaffold and split suite-ingress/suite-feature e2e-test: support more default value in NewScaffold and split suite-ingress/suite-features Jul 4, 2022
@AlinsRan AlinsRan changed the title e2e-test: support more default value in NewScaffold and split suite-ingress/suite-features e2e-test: split suite-ingress/suite-features, and support more default value in NewScaffold Jul 4, 2022
@AlinsRan AlinsRan changed the title e2e-test: split suite-ingress/suite-features, and support more default value in NewScaffold e2e-test: Optimize the runrime of ingress/features, and support more default value in NewScaffold Jul 4, 2022
@AlinsRan AlinsRan changed the title e2e-test: Optimize the runrime of ingress/features, and support more default value in NewScaffold e2e-test: Optimize the runtime of ingress/features, and support more default value in NewScaffold Jul 4, 2022
@AlinsRan AlinsRan mentioned this pull request Jul 4, 2022
Closed
12 tasks
@AlinsRan AlinsRan marked this pull request as ready for review July 4, 2022 05:40
@lingsamuel lingsamuel requested review from lingsamuel and tao12345666333 and removed request for lingsamuel July 4, 2022 08:42
lingsamuel
lingsamuel reviewed Jul 4, 2022
View reviewed changes
test/e2e/scaffold/scaffold.go Outdated Show resolved Hide resolved
test/e2e/scaffold/k8s.go Outdated Show resolved Hide resolved
test/e2e/suite-ingress/suite-ingress-resource/resourcepushing.go Outdated Show resolved Hide resolved
test/e2e/suite-ingress/suite-ingress-resource/resourcepushing.go Outdated Show resolved Hide resolved
@AlinsRan AlinsRan requested a review from lingsamuel July 5, 2022 02:29
tao12345666333
tao12345666333 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333
Copy link
Member

ping @lingsamuel for reveiw, thanks

@tao12345666333 tao12345666333 merged commit 398f816 into apache:master Jul 6, 2022
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Jul 6, 2022
@tao12345666333 tao12345666333 linked an issue Jul 6, 2022 that may be closed by this pull request
test: support more default value in NewScaffold #1127
Closed
@tao12345666333 tao12345666333 mentioned this pull request Jul 6, 2022
Closed
@AlinsRan AlinsRan deleted the e2e/fix branch July 29, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@lingsamuel lingsamuel lingsamuel approved these changes

Assignees
No one assigned
Labels
area/test
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

test: support more default value in NewScaffold
4 participants
@AlinsRan @codecov-commenter @tao12345666333 @lingsamuel