New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update crd version #1134
docs: update crd version #1134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution,
But I hope you can modify other related content at the same time.
Modify the API version in the following documents to v2beta3
.
And note that in case of ApisixRoute resource, we have removed the spec.http.backend
field and need to update it to spec.http.backends
docs/en/latest/tutorials/proxy-grpc-service.md
109:apiVersion: apisix.apache.org/v1
137:apiVersion: apisix.apache.org/v1
docs/en/latest/tutorials/mtls/tls.yaml
17:apiVersion: apisix.apache.org/v1
docs/en/latest/tutorials/mtls/mtls.yaml
17:apiVersion: apisix.apache.org/v1
docs/en/latest/concepts/apisix_upstream.md
35:apiVersion: apisix.apache.org/v1
61:apiVersion: apisix.apache.org/v1
80:apiVersion: apisix.apache.org/v1
131:apiVersion: apisix.apache.org/v1
143:apiVersion: apisix.apache.org/v1
162:apiVersion: apisix.apache.org/v1
docs/en/latest/concepts/apisix_tls.md
30:apiVersion: apisix.apache.org/v1
and
docs/en/latest/concepts/apisix_cluster_config.md
38:apiVersion: apisix.apache.org/v2alpha1
61:apiVersion: apisix.apache.org/v2alpha1
About this Ci error #1137, you need to merge the latest code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you change spec.http.backend
to spec.http.backends
, you should add -
before serviceName
. Because its a sequence(list)
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Don't forget to update this PR's template :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change:
What this PR does / why we need it:
Pre-submission checklist: