Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update crd version #1134

Merged
merged 4 commits into from Jul 12, 2022
Merged

docs: update crd version #1134

merged 4 commits into from Jul 12, 2022

Conversation

Gallardot
Copy link
Member

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333 tao12345666333 added the documentation Improvements or additions to documentation label Jul 6, 2022
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution,
But I hope you can modify other related content at the same time.

Modify the API version in the following documents to v2beta3 .
And note that in case of ApisixRoute resource, we have removed the spec.http.backend field and need to update it to spec.http.backends

docs/en/latest/tutorials/proxy-grpc-service.md
109:apiVersion: apisix.apache.org/v1
137:apiVersion: apisix.apache.org/v1

docs/en/latest/tutorials/mtls/tls.yaml
17:apiVersion: apisix.apache.org/v1

docs/en/latest/tutorials/mtls/mtls.yaml
17:apiVersion: apisix.apache.org/v1

docs/en/latest/concepts/apisix_upstream.md
35:apiVersion: apisix.apache.org/v1
61:apiVersion: apisix.apache.org/v1
80:apiVersion: apisix.apache.org/v1
131:apiVersion: apisix.apache.org/v1
143:apiVersion: apisix.apache.org/v1
162:apiVersion: apisix.apache.org/v1

docs/en/latest/concepts/apisix_tls.md
30:apiVersion: apisix.apache.org/v1

and

docs/en/latest/concepts/apisix_cluster_config.md
38:apiVersion: apisix.apache.org/v2alpha1
61:apiVersion: apisix.apache.org/v2alpha1

@AlinsRan
Copy link
Contributor

AlinsRan commented Jul 7, 2022

About this Ci error #1137, you need to merge the latest code.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you change spec.http.backend to spec.http.backends , you should add - before serviceName. Because its a sequence(list)

Thanks!

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Don't forget to update this PR's template :)

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 73498bd into apache:master Jul 12, 2022
@Gallardot Gallardot deleted the patch-1 branch July 12, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants