Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support endpointslice, and improve test/e2e/endpoints.go tests. #1140

Merged
merged 12 commits into from
Jul 11, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Jul 8, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Reference #552 :

  • This problem does not exist.
  • Supplement relevant e2e-test cases.

Reference #1064 #674 :

  • Support endpointslice.
  • Supplement relevant e2e-test cases.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #1140 (126a71e) into master (62e0ea2) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
- Coverage   30.24%   30.21%   -0.04%     
==========================================
  Files          81       81              
  Lines        9453     9463      +10     
==========================================
  Hits         2859     2859              
- Misses       6279     6289      +10     
  Partials      315      315              
Impacted Files Coverage Δ
pkg/ingress/endpoint.go 0.00% <0.00%> (ø)
pkg/ingress/endpointslice.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0217ae...126a71e. Read the comment docs.

@AlinsRan AlinsRan marked this pull request as ready for review July 8, 2022 08:06
@tao12345666333 tao12345666333 self-assigned this Jul 8, 2022
test/e2e/suite-endpoints/endpoints.go Outdated Show resolved Hide resolved
test/e2e/suite-endpoints/endpoints.go Outdated Show resolved Hide resolved
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit a73b52d into apache:master Jul 11, 2022
AlinsRan added a commit to AlinsRan/apisix-ingress-controller that referenced this pull request Jul 12, 2022
AlinsRan added a commit to AlinsRan/apisix-ingress-controller that referenced this pull request Jul 12, 2022
@AlinsRan AlinsRan deleted the e2e/endpoint branch July 29, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants