Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: add e2e tests and CRDs for ApisixUpstream v2 #1147

Merged
merged 6 commits into from
Jul 13, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Jul 12, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

#954

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #1147 (554e2e0) into master (a649751) will increase coverage by 0.02%.
The diff coverage is 28.57%.

❗ Current head 554e2e0 differs from pull request most recent head 2fc61f1. Consider uploading reports for the commit 2fc61f1 to get more accurate results

@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
+ Coverage   30.53%   30.55%   +0.02%     
==========================================
  Files          81       81              
  Lines        9895     9860      -35     
==========================================
- Hits         3021     3013       -8     
+ Misses       6549     6522      -27     
  Partials      325      325              
Impacted Files Coverage Δ
cmd/ingress/ingress.go 78.84% <ø> (-0.79%) ⬇️
pkg/ingress/compare.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 0.38% <0.00%> (+0.01%) ⬆️
pkg/ingress/secret.go 0.00% <0.00%> (ø)
pkg/config/config.go 65.34% <100.00%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a649751...2fc61f1. Read the comment docs.

@AlinsRan AlinsRan changed the title e2e: support upstream v2 e2e-test: add e2e tests and CRDs for ApisixUpstream v2 Jul 12, 2022
@AlinsRan AlinsRan marked this pull request as ready for review July 12, 2022 09:06
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixTlsVersion, "apisix-tls-version", config.ApisixV2beta3, "the supported apisixtls api group version, can be \"apisix.apache.org/v2beta3\" or \"apisix.apache.org/v2\"")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixClusterConfigVersion, "apisix-cluster-config-version", config.ApisixV2beta3, "the supported ApisixClusterConfig api group version, can be \"apisix.apache.org/v2beta3\" or \"apisix.apache.org/v2\"")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixConsumerVersion, "apisix-consumer-version", config.ApisixV2beta3, "the supported ApisixConsumer api group version, can be \"apisix.apache.org/v2beta3\" or \"apisix.apache.org/v2\"")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixRouteVersion, "apisix-route-version", config.DefaultAPIVersion, "the supported apisixroute api group version, can be \"apisix.apache.org/v2beta2\" or \"apisix.apache.org/v2beta3\"")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.APIVersion, "api-version", config.DefaultAPIVersion, config.APIVersionDescribe)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add v2

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 35ca03c into apache:master Jul 13, 2022
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Jul 13, 2022
@tao12345666333 tao12345666333 linked an issue Jul 13, 2022 that may be closed by this pull request
16 tasks
@AlinsRan AlinsRan deleted the e2e/upstream/v2 branch July 29, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add v2 API version support for all resources
4 participants