ci: upgrade e2e-test-ci #1149
ci: upgrade e2e-test-ci #1149
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
=======================================
Coverage 30.45% 30.45%
=======================================
Files 81 81
Lines 9839 9839
=======================================
Hits 2996 2996
Misses 6517 6517
Partials 326 326 Continue to review full report at Codecov.
|
AlinsRan
force-pushed
the
ci/e2e
branch
16 times, most recently
from
ed2024a
to
ac3bb93
Compare
| docker tag apache/apisix:2.13.1-alpine $(REGISTRY)/apache/apisix:$(IMAGE_TAG) | ||
|
|
||
| docker pull bitnami/etcd:3.4.14-debian-10-r0 | ||
| docker tag bitnami/etcd:3.4.14-debian-10-r0 $(REGISTRY)/bitnami/etcd:$(IMAGE_TAG) | ||
|
|
||
| docker pull kennethreitz/httpbin | ||
| docker tag kennethreitz/httpbin $(REGISTRY)/kennethreitz/httpbin:$(IMAGE_TAG) | ||
|
|
||
| docker build -t test-backend:$(IMAGE_TAG) --build-arg ENABLE_PROXY=$(ENABLE_PROXY) ./test/e2e/testbackend | ||
| docker tag test-backend:$(IMAGE_TAG) $(REGISTRY)/test-backend:$(IMAGE_TAG) | ||
|
|
||
| docker build -t apache/apisix-ingress-controller:$(IMAGE_TAG) --build-arg ENABLE_PROXY=$(ENABLE_PROXY) . | ||
| docker tag apache/apisix-ingress-controller:$(IMAGE_TAG) $(REGISTRY)/apache/apisix-ingress-controller:$(IMAGE_TAG) | ||
|
|
||
| docker pull jmalloc/echo-server:latest | ||
| docker tag jmalloc/echo-server:latest $(REGISTRY)/jmalloc/echo-server:$(IMAGE_TAG) | ||
|
|
||
| docker pull busybox:1.28 | ||
| docker tag busybox:1.28 $(REGISTRY)/busybox:$(IMAGE_TAG) |
There was a problem hiding this comment.
I do not recommend unifying the tags of these images into dev.
If the task fails, we need to check the code to know which image is used.
Can you explain your benefit of unifying them?
There was a problem hiding this comment.
The advantage of this is that because we use a local repository, we don't need to care about these images tags in the code. When upgrading, we only need to change the Makefile file.
At present, localhost:5000 is used to identify the local warehouse in our code. It's not difficult to track this problem.
There was a problem hiding this comment.
make sense, let's move forward.
Type of change:
What this PR does / why we need it:
ref: #1164
EnsureNum...func to ensure resource update.It will retry 6 times to ensure the stability above 80%
retry 6 times:
pass: 6
faild: 0